Re: [0/25] Merge pmdisk and swsusp

From: Pavel Machek
Date: Sun Jul 18 2004 - 17:28:04 EST


Hi!

> Please pull from
>
> bk://kernel.bkbits.net:/home/mochel/linux-2.6-power

I noticed that it now fixes swap signatures early, good.

> <mochel@xxxxxxxxxxxxxxxxxx> (04/07/17 1.1865)
> [swsusp] Remove unneeded suspend_pagedir_lock.

How do you guarantee that while copying pages back and forth,
interrupts are disabled? They have to be, because memory snapshots are
no longer atomic.

In one patch, there's "Invalid partition" message when there's
incorrect signature may be confusing.

Otherwise patches are good. Perhaps it is easier to merge them with
Andrew now and fix remaining few issues with follow up patches?
Pavel
--
Horseback riding is like software...
...vgf orggre jura vgf serr.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/