Re: [PATCH] pmac_zilog: initialize port spinlock on all init paths

From: Tom Rini
Date: Fri Jul 16 2004 - 15:52:29 EST


On Fri, Jul 16, 2004 at 04:15:15PM -0400, David Eger wrote:

> On Wed, Jul 14, 2004 at 04:39:20PM -0700, Tom Rini wrote:
> > On Wed, Jul 14, 2004 at 12:04:03AM -0400, David Eger wrote:
> > > > > ( of course, it still spews diahrea of 'IN from bad port XXXXXXXX'
> > > > > but then, I don't have the hardware.... still, seems weird that OF
> > > > > would report that I do have said hardware :-/ )
> > > >
> > > > The IN from bad port is a different issue, it's probably issued by
> > > > another driver trying to tap legacy hardware, either serial.o or
> > > > ps/2 kbd, I suppose, check what else of that sort you have in your
> > > > .config
> > >
> > > Sure enough, the "IN from bad port XXXXXXXX" ended up being the i8042
> > > serial PC keyboard driver, enabled with CONFIG_SERIO_I8042. Don't know
> > > why that's in ppc defconfig....
> >
> > That's on for all of the ppc boards with an i8042 which the defconfig is
> > supposed to support (prep & chrp hardware).
>
> Sorry, I tend to think "ppc == pmac". So, a couple of thoughts:
>
> (1) Can you make the i8042 disable itself if the hardware isn't there?
> Those damned bad port messages eat my entire syslog buffer.

Ask Vojtech Pavlik.

> (2) At the moment, that defconfig is also shared by us TiBook hackers.
> Would it be feasible to have a separate pmac_defconfig? How do
> 'make menuconfig' and friends choose a defconfig if there isn't a .config?

One already exists. The short answer is that when .config doesn't
exist, we look at /boot/config-`uname -r` and then
arch/$(ARCH)/defconfig. I believe the that 'make help' mentions the
next neat trick. If you do 'make pmac_defconfig' for example,
arch/ppc/configs/pmac_defconfig is used as the base of a new .config
file, with all options not documented in that file being set to 'n'.
You can then either build the kernel, or further tweak via
menuconfig/etc.

--
Tom Rini
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/