Re: Linux 2.6.8-rc1

From: OGAWA Hirofumi
Date: Mon Jul 12 2004 - 08:21:43 EST


Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes:

> On Sun, 11 Jul 2004, Linus Torvalds wrote:
> > Hirofumi Ogawa:
> > o FAT: don't use "utf8" charset and NLS_DEFAULT
>
> This patch breaks compilation if both MSDOS_FS and VFAT_FS are not set, due to
> CONFIG_FAT_DEFAULT_CODEPAGE being undefined.
>
> Suggested fix: either make FAT_DEFAULT_CODEPAGE depend on FAT_FS only
> (compilation of fs/fat/inode.c depends on FAT_FS), or add a test for
> CONFIG_FAT_DEFAULT_CODEPAGE being undefined, cfr. the test for
> CONFIG_FAT_DEFAULT_IOCHARSET in fs/fat/inode.c.

Why did you need only FAT_FS? If it was not needed, I'll remove the
configurable FAT_FS, instead it is internally used only.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/