Re: [PATCH] radeonfb: cleanup and little fixes

[David Eger]

On Sun, Jul 11, 2004 at 11:30:02PM -0700, Andrew Morton wrote:
> >  	if (rinfo->mon1_EDID)
> >  	    kfree(rinfo->mon1_EDID);
> >  	if (rinfo->mon2_EDID)
> >  	    kfree(rinfo->mon2_EDID);
> 
> kfree(NULL) is legal, and this is a slow-path.  Those tests can be taken
> out next time, unless such a thing offends you.

I guess I wasn't zealous enough in my cleanup ;-)
(changing it doesn't bother me, I just hadn't noticed it)

I really appreciate the work you put in looking through all of the
patches you get.  Code review is a huge job, something I don't think
James really has time for, but somehow you find it :)

-dte
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/