Re: [PATCH] [2.6] PPC64: log firmware errors during boot.

From: Jake Moilanen
Date: Tue Jul 06 2004 - 08:29:01 EST


>
> On Fri, 2004-07-02 at 11:18, Nathan Fontenot wrote:
> > > I asked about this before, and was told that there is no way to
> > > determine the severity of an event without doing full parsing of the
> > > binary data. I'd be thrilled to be wrong...
> >
> > Gettting the severity of an RTAS event is possible, and not too
> > difficult. Check out asm-ppc64/rtas.h for a definition of the
> > RTAS event header (struct rtas_error_log). All RTAS events have the
> > same initial header containing the severity of the event.
>
> Great! Of course that won't help much if we get repeating "important"
> events that aren't even interesting much less important, but it's worth
> trying to printk only the important ones and leave the rest to netlink.
>
> Note that currently we printk them all as KERN_DEBUG messages. Although
> they aren't spewed to console, they still take up (lots of) space in the
> printk buffer, and dmesg is still afflicted too...
>

The original "plan" for error logging was to eventually take out the
printk's all together once we could get ela (the userspace daemon
responsible for parsing error messages and routing them appropriately)
into all distros. We didn't want the possibility of a customer losing a
vital message by not having ela installed.

I would propose the making the printk's of the messages a kernel config
option. Then the distros could turn it on or off depending on if they
are packaging ela. All messages should still go to userspace though.
This will alleviate the spamming of the printk buffer.

I have no problems in moving communication between kernel and userspace
to netlink. Whomever makes the change needs to keep Mike Strosaker and
Nathan Fontenot informed since they are maintaining the user space
counterpart.

Thanks,
Jake
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/