Re: [PATCH] 2.6 PPC64 EEH unbalanced dev_get/put calls

[Paul Mackerras]

Linas,

> This patch fixes some unbalanaced usage of pci_dev_get()/pci_dev_put() calls
> in the eeh code.  The old code had too many calls to dev_put, which could
> cause memory structs to be freed prematurely, possibly leading to bad
> bad pointer derefs in certain cases.

When I apply this I end up with one pci_dev_get() call in
__pci_addr_cache_insert_device and no pci_dev_put() calls.  That can't
be right, surely?  If it is it needs a big fat comment explaining why.

> Cross-ref LTC bug 9283

Confused - that's the bug about not using ibm,fw-phb-id.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/