Re: [PATCH] 2.6 PPC64: lockfix for rtas error log (third-times-a-charm?)]

[linas]

On Thu, Jul 01, 2004 at 01:39:38PM -0700, Greg KH wrote:
> 
> And shouldn't you return -ENOMEM if you are out of memory, and can't log
> the message?

The current architected interface for this routine is to return
the error code as generated by firmware, and not an error code that
might be gen'ed during call execution.  If we change this convention,
then we'd have to audit all 68 uses of this routine to see if any
are affected, and fix the ones that are.  This is a potentially 
error-prone process. Also, the likelyhood of having a failed rtas
call is supposed to be very small (ideally never), to hava a failed
call *and* be out of memory to record the failure seems dim ... 
the benefit doesn't seem worth it.


--linas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/