Re: [PATCH] restore floppy boot image

[Randy.Dunlap]

On Wed, 30 Jun 2004 17:52:30 -0400 (EDT) Joshua wrote:

| Thanks for the time in reading the patch.
| 
| Hmm. pop %ax after the jmp is a clear bug. Must have been a zero
| on the stack when I tested it. <g>
| 
| For the clobbering of al just before kernel entry, that is badly arranged
| code although it doesn't matter (mov $0, %al turns out to be no-op).

No-op should be some form/variant of xchg %ax,%ax 
(not mov to %al -- the latter needs to do something.)

| I'll fix the bugs if anybody still wants the patch.
| I'll fix it anyway for myself <g>.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/