Re: [PATCH]2.6.7 MSI-X Update

[Jeff Garzik]

Roland Dreier wrote:
> This looks good, a definite improvement over what's currently in the
> kernel.  I do have one question about the whole msi.c file (and this
> applies to the code that's already in the tree, too).  Why is config
> space being accessed via calls like
>
> 	dev->bus->ops->read(dev->bus, dev->devfn, ... )
>
> instead of just calling
>
>         pci_read_config_word(dev, ... )
>
> The only difference seems to be that MSI is bypassing the locking in
> access.c.  Is there some reason for this?

hmmmmmmm.

Unless it's already inside the lock somehow...  it definitely needs to 
take the lock, one way or another.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/