Re: [patch 2.6.7] bug_smp_call_function

[Andrew Morton]

Keith Owens <kaos@xxxxxxx> wrote:
>
>  sg.c has been fixed to no longer call vfree() with interrupts disabled.
>  Change smp_call_function() from WARN_ON to BUG_ON when interrupts are
>  disabled.  It was only set to WARN_ON because of sg.c.

I prefer the WARN_ON.  It is exceedingly unlikely that the bug will cause
lockups or memory/data corruption or anything else, so why nuke the user's
box when we can trivially continue?

We'll be sent the bug report either way.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/