Re: [PATCH] [STACK] >3k call path in ide

[Florian Schirmer]

Hi,

> Leak memory.  I also tend to depend on the fact that kfree(NULL) works
> just fine:
>
> err_kfree:
> 	kfree(cfginfo);
> 	kfree(def_cte);
> 	kfree(tbuf);
> 	printk(KERN_NOTICE "ide-cs: ide_config failed memory allocation\n");
> 	goto failed;
>
> Makes the error path a little simpler.
>  

Nope. It will deadlock just like the original patch because failed falls 
through to err_kfree which then will jump to failed...

Regards,
   Florian

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/