Re: [PATCH] IDE update for 2.6.7-rc3 [1/12]

From: Christoph Hellwig
Date: Sat Jun 12 2004 - 05:36:35 EST


On Fri, Jun 11, 2004 at 05:50:30PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> Probably some drivers are still missed because I changed only
> these drivers that I knew that there are PCI cards using them.
>
> If you know about PCI cards using other drivers please speak up.

IMHO the PCI ->probe methods should always be __devinit. It's rather
hard to make sure they're never every hotplugged in any way, especially
with the dynamic id adding via sysfs thing.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/