Re: [ANNOUNCE] high-res-timers patches for 2.6.6

From: George Anzinger
Date: Fri Jun 11 2004 - 17:36:00 EST


Arjan van de Ven wrote:
On Thu, Jun 10, 2004 at 05:02:23PM -0700, George Anzinger wrote:

Arjan van de Ven wrote:

On Thu, 2004-06-10 at 03:49, Geoff Levand wrote:


Available at http://tree.celinuxforum.org/pubwiki/moin.cgi/CELinux_5fPatchArchive

For those interested, the set of three patches provide POSIX high-res timer support for linux-2.6.6. The core and i386 patches are updates of George Anzinger's hrtimers-2.6.5-1.0.patch available on SourceForge <http://sourceforge.net/projects/high-res-timers/>. The ppc32 port is not available on SourceForge yet.


My first impression is that it has WAAAAAAAAAAAY too many ifdefs. I
would strongly suggest to not make this a config option and just
mandatory, it's a core feature that has no point in being optional. If
you accept that, the code also becomes a *LOT* cleaner.

Can I be so bold as to ask about the changed to the timer list code? Assuming we scrapped all the ifdefs, that is.

I have been thinking of a major rewrite which would leave this code alone, but would introduce an additional list and, of course, overhead for high-res timers. This will take some time and be sub optimal, so I wonder if it is needed.

--
George Anzinger george@xxxxxxxxxx
High-res-timers: http://sourceforge.net/projects/high-res-timers/
Preemption patch: http://www.kernel.org/pub/linux/kernel/people/rml

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/