Re: 2.6.7-rc3: nforce2, no C1 disconnect fixup applied

[Craig Bradney]

On Fri, 2004-06-11 at 00:26, Bartlomiej Zolnierkiewicz wrote:
> On Friday 11 of June 2004 00:00, Craig Bradney wrote:
> > On Thu, 2004-06-10 at 23:56, Bartlomiej Zolnierkiewicz wrote:
> > > On Thursday 10 of June 2004 23:36, Lars wrote:
> > > > thanks
> > > >
> > > > after some reading, im using now in rc.local:
> > > >
> > > > ### C1 Halt Disconnect Fix for Chip rev. C17
> > > > setpci -H1 -s 0:0.0 6F=1F
> > > > setpci -H1 -s 0:0.0 6E=01
> > > > echo "Applying C1 Halt Disconnect Fix"
> > > >
> > > > this is for an older nforce2 board (a7n8x 1.04) with rev. C17 chip
> > > > and worked fine so far.
> > > >
> > > > for the newer chip revision it should read
> > > >
> > > > ### C1 Halt Disconnect Fix for Chip rev. C18D
> > > > setpci -H1 -s 0:0.0 6F=9F
> > > > setpci -H1 -s 0:0.0 6E=01
> > > > echo "Applying C1 Halt Disconnect Fix"
> > > >
> > > > first setpci is for the c1 halt bit and the second one enables the
> > > > 80ns stability value.
> > >
> > > Order should be reversed.
> > >
> > > > i understand that its not good to enable c1 for all boards, but it
> > > > would be nice to have the option to force the fixup on boards which
> > > > work ok but have no bios option to enable c1. (like the a7n8x)
> > > > an bootoption like "forceC1halt" or something would be nice here.
> > >
> > > It can be perfectly handled in user-space as you've just showed. :-)
> > > There is no need to add complexity to the kernel.
> >
> > Except if people have the trouble when installing Linux.... ok, yes,
> 
> What trouble are you talking about?
> 
> Fix is in the kernel and is applied when C1 Halt Disconnect is enabled.
> If  C1 H.D. is disabled you need to enable it somehow from user-space,
> thus you can apply fixup from user-space at the same time.
> 
> > they can still be done somehow, but thats just ugly for the "put cd in
> > and install" users. Surely the kernel should be detecting this stuff and
> > using various options as required.
> 
> If you think that kernel should have options for all PCI tweaks
> available than sorry but you are wrong (grab powertweak instead).


Well.. no.. I dont suggest that the kernel apply fixes for all the buggy
motherboards and other h/w out there.. but I guess the distro builders
need to make sure these post boot options are being set based on
hardware detected, or something. :)

Craig

Attachment: signature.asc
Description: This is a digitally signed message part