Re: [PATCH] 2.6.7-rc2-mm2 perfctr #if/#ifdef cleanup

From: Mikael Pettersson
Date: Tue Jun 08 2004 - 08:53:26 EST


On Mon, 07 Jun 2004 16:23:31 -0400, Valdis.Kletnieks@xxxxxx wrote:
> Cleaning up some #if/#ifdef confusion in the perfctr patch...

To clarify: the confusion is not that those two symbols
(PERFCTR_CPUS_FORBIDDEN_MASK_NEEDED and PERFCTR_INTERRUPT_SUPPORT)
are tested with #if in some places and #ifdef in others;
instead it is that the symbols are either 1 or undefined,
but always tested with #if. This, while valid C, may seem
slightly strange.

Thanks Valdis for pointing this out. I'll clean this up.

Andrew: please apply Valdis' cleanup patch.
(I can send a new one if you didn't save it.)

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/