[PATCH]linux-2.6.7-rc3_cyclone-bad-pit_A0

[john stultz]

All,
	In testing for SLES9, we ran across a bug caused by userspace apps
poking the PIT which caused bad values to be read by the kernel. This
would then trigger the lost tick detection code with insane values and
would then break the SCSI subsystem. 
	
	This patch includes the PIT sanity check from the TSC timesource into
the cyclone timesource code, which catches the bad case described above
and resolves the issue.

Please apply.

thanks
-john

diff -Nru a/arch/i386/kernel/timers/timer_cyclone.c b/arch/i386/kernel/timers/timer_cyclone.c
--- a/arch/i386/kernel/timers/timer_cyclone.c	Mon Jun  7 17:02:41 2004
+++ b/arch/i386/kernel/timers/timer_cyclone.c	Mon Jun  7 17:02:41 2004
@@ -17,6 +17,7 @@
 #include <asm/io.h>
 #include <asm/pgtable.h>
 #include <asm/fixmap.h>
+#include "io_ports.h"
 
 extern spinlock_t i8253_lock;
 
@@ -62,6 +63,17 @@
 
 	count = inb_p(0x40);    /* read the latched count */
 	count |= inb(0x40) << 8;
+
+	/*
+	 * VIA686a test code... reset the latch if count > max + 1
+	 * from timer_pit.c - cjb
+	 */
+	if (count > LATCH) {
+		outb_p(0x34, PIT_MODE);
+		outb_p(LATCH & 0xff, PIT_CH0);
+		outb(LATCH >> 8, PIT_CH0);
+		count = LATCH - 1;
+	}
 	spin_unlock(&i8253_lock);
 
 	/* lost tick compensation */


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/