Re: [HOWTO...] LUFS, readpage and large files

From: Andrew Morton
Date: Fri Jun 04 2004 - 23:53:14 EST


Eduard Bloch <blade@xxxxxxxxxx> wrote:
>
> offset = p->index << PAGE_CACHE_SHIFT;
> count = PAGE_SIZE;
>
> The problem is, page->index indeed contains a short datatype for offset -
> ...but where to get the correct data? (the long long offset).

p->index is a 32-bit type. So (p->index << PAGE_CACHE_SHIFT) is also
32-bit, and stuff overflows. Do:

offset = p->index;
offset <<= PAGE_CACHE_SHIFT;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/