Re: [PATCH] Driver Core fixes for 2.6.7-rc1

From: Greg KH
Date: Fri Jun 04 2004 - 13:47:12 EST


On Fri, Jun 04, 2004 at 08:26:00PM +0200, Pavel Machek wrote:
> Hi!
>
> > > > [PATCH] Report which device failed to suspend
> > > >
> > > > Based on a patch from Nickolai Zeldovich <kolya@xxxxxxx> but put into the
> > > > proper place by me.
> > >
> > > Seems good.
> > >
> > > I'm seeing lots of problems with drivers & swsusp these days. Perhaps
> > > even printing names of devices as they are suspended is good idea?
> >
> > You mean like the current kernel tree does if you enable
> > CONFIG_DEBUG_DRIVER? :)
>
> Well, something little less verbose but enabled by default would do
> the trick.

I don't think the current one is all that verbose, it just prints out
one line for every device being suspended. And if a user is having
problems, it's quite easy to ask them to enable that option and send the
output from a failed suspend.

But if you have a patch to change it, please send it.

thanks,

greg k-h


> Pavel
> --
> 934a471f20d6580d5aad759bf0d97ddc
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/