Re: [RFC PATCH] explicitly mark recursion count

From: Jörn Engel
Date: Tue Jun 01 2004 - 08:28:49 EST


On Tue, 1 June 2004 13:39:22 +0100, viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx wrote:
>
> > +/**
> > + * RECURSION: 100
> > + * STEP: register_proc_table
> > + */
>
> This is too ugly for words ;-/ Who will maintain that data, anyway?

What format do you propose? I don't care too much.

Maintenance would get easier with less recursions, obviously. ;)

I could hack up something that will generate digests from the function
source code (through smatch or so) and put those digests into the
comments. As long as they match, the comments remain valid. And that
should get past lawyers, as I work on a different basis now.

Jörn

--
Data dominates. If you've chosen the right data structures and organized
things well, the algorithms will almost always be self-evident. Data
structures, not algorithms, are central to programming.
-- Rob Pike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/