BUG FIX: atkbd.c keyboard driver bug [Was: keyboard problem with 2.6.6]

[Sau Dan Lee]

>>>>> "bugme-daemon" == bugme-daemon  <bugme-daemon@xxxxxxxx> writes:

    bugme-daemon> http://bugme.osdl.org/show_bug.cgi?id=2808
    bugme-daemon> vojtech@xxxxxxx changed:

    bugme-daemon>    What    |Removed             |Added
    bugme-daemon> ----------------------------------------------------
    bugme-daemon>      Status|NEW                 |REJECTED
    bugme-daemon>  Resolution|                    |INVALID

    Vojtech> I'm sorry you can't use the fn+printscreen function on
    Vojtech> your LifeBook, but such is life. 

Disappointed.


    Vojtech> Is using Alt+printscreen such a big difference?

That means I need to press FOUR keys to use sysrq, because PrintScreen
is  only  available via  [Fn].   That becomes  [Fn]+Alt+PrintScreen+X,
where "X" is the sysrq function.  :(


    Vojtech> On USB keyboards (and many others, too), there is no
    Vojtech> specific SysRq keycode, and thus the kernel magic-sysrq
    Vojtech> handler uses the alt-printscreen combination, to make it
    Vojtech> work on ALL keyboards. This is intentional.

Isn't  the keyboard  driver  supposed to  iron  out such  differences?
Isn't  it your  philosophy that  the drivers  should know  the devices
well, and present  a consistent interface to the  upper layers?  Then,
the correct way to do it is:

        USB keyboard driver: generate a "sysrq" event in reaction to
                             Alt-PrintScreen 
        AT/PS2 keyboard driver: generate a "sysrq" when receiving a
                                0x54 keycode

The  kernel  keyboard  handler  shouldn't  see  or  bother  about  the
difference.   It is  insane that  the handler  has to  care  about the
status of the Alt keys.


    Vojtech> Further, keycode 99 is KEY_SYSRQ, as defined in input.h,

Then, why use it for PrintScreen?   With the 'evbug' facility, I see a
keyboard  event with code  KEY_SYSRQ when  I press  PrintScreen.  Just
PrintScreen, not  Alt-PrintScreen.  So,  this is a  feature and  not a
bug?


    Vojtech> and is used for the PrtScr/SysRq key. 

So, why not have seperate keycodes for the two?



-- 
Sau Dan LEE                     ???(Big5)                    ~{@nJX6X~}(HZ) 

E-mail: danlee@xxxxxxxxxxxxxxxxxxxxxxxxxx
Home page: http://www.informatik.uni-freiburg.de/~danlee

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/