Re: [PPC64] Remove silly debug path from get_vsid()

From: Paul Mackerras
Date: Thu May 27 2004 - 23:56:16 EST


Andreas Dilger writes:

> so presumably if you don't select CONFIG_PPCDBG it is also a no-op unless
> the compiler is broken and doesn't optimize away "if (0)" stanzas. The
> original construct gives you the option to enable this particular debugging
> at runtime (without necessarily enabling all debugging at one time) if wanted.

And the effect of suddenly changing your VSID calculation algorithm in
mid-stream is pretty catastrophic. There is no sensible reason
wanting to be able to turn this on and off at runtime. This is not
just some extra checking.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/