RE: idebus setup problem (2.6.7-rc1)

[Zhu, Yi]

linux-kernel-owner@xxxxxxxxxxxxxxx wrote:
> Bartlomiej Zolnierkiewicz wrote:
>> 
>> It breaks all "idex=" and "hdx=" options.
>> Please take a look at how ide_setup().
> 
> Yes, thanks for pointing out. Maybe we need some wildcard
> support. If module_param() can do this, that's great.

Does below change acceptable to make module_param support 
wildcard '?' ?

--- linux-2.6.6.orig/kernel/params.c        2004-05-28
00:13:24.931368296 +0800
+++ linux-2.6.6/kernel/params.c     2004-05-28 00:16:04.406124448 +0800
@@ -37,7 +37,8 @@ static inline int dash2underscore(char c
 static inline int parameq(const char *input, const char *paramname)
 {
        unsigned int i;
-       for (i = 0; dash2underscore(input[i]) == paramname[i]; i++)
+       for (i = 0; paramname[i] == '?' ||
+            dash2underscore(input[i]) == paramname[i]; i++)
                if (input[i] == '\0')
                        return 1;
        return 0;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/