Re: alpha fp-emu vs module refcounting

From: Christoph Hellwig
Date: Fri May 07 2004 - 18:59:12 EST


On Sat, May 08, 2004 at 02:37:17AM +0400, Ivan Kokshaysky wrote:
> Ok, I realize - this seems to be confusing. I'll try to clarify:
> - First of all, mere mortals are _not_ allowed to compile mandatory
> alpha IEEE fp emulation code as a module. Which is documented
> in arch/alpha/Kconfig.
> - Roughly speaking, the fp emu _module_ code intercepts the fp traps,
> so races vs module loading/unloading are fundamentally unavoidable.
> These refcounting attempts just narrow the window.
>
> And no, try_module_get should never fail here.
>
> Alternatively, we could just drop _all_ module related stuff from
> alpha/math-emu...

either that or just marking it unloadable by removing the cleanup_module
handler sound like the simplest solution I guess.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/