Re: [RFC] handshake variable with DTR DSR DCD ...

[Jan-Benedict Glaw]

On Fri, 2004-05-07 16:54:13 +0200, Michael Westermann <mw@xxxxxxxxxxxxxxxx>
wrote in message <20040507165413.D16132@xxxxxxxxxxxxxxxx>:
> diff -Nurp linux-2.4.26.old/drivers/char/serial.c linux-2.4.26/drivers/char/serial.c
> --- linux-2.4.26.old/drivers/char/serial.c	2004-02-18 14:36:31.000000000 +0100
> +++ linux-2.4.26/drivers/char/serial.c	2004-05-07 16:42:19.000000000 +0200
> @@ -769,9 +769,12 @@ static _INLINE_ void check_modem_status(
>  	}
>  	if (info->flags & ASYNC_CTS_FLOW) {
>  		if (info->tty->hw_stopped) {
> -			if (status & UART_MSR_CTS) {
> +			if (status & info->status_flow) {
>  #if (defined(SERIAL_DEBUG_INTR) || defined(SERIAL_DEBUG_FLOW))
> -				printk("CTS tx start...");
> +				if (info->status_flow & UART_MSR_CTS)
> +					printk("CTS tx start...");
> +				else 
> +				    	printk("HW %x tx start...", info->status_flow);

A "\n" is missing here and was already missing in the initial version.

>  #if (defined(SERIAL_DEBUG_INTR) || defined(SERIAL_DEBUG_FLOW))
> -				printk("CTS tx stop...");
> +				if (info->status_flow & UART_MSR_CTS)
> +				    	printk("CTS tx stop...");
> +				else
> +				    	printk("HW %x tx stop...", info->status_flow);

Dito.

> --- linux-2.4.26.old/include/asm-i386/termbits.h	2000-01-21 01:05:26.000000000 +0100
> +++ linux-2.4.26/include/asm-i386/termbits.h	2004-05-07 16:43:39.000000000 +0200
> @@ -132,6 +132,7 @@ struct termios {
>  #define  B3000000 0010015
>  #define  B3500000 0010016
>  #define  B4000000 0010017
> +#define CHWFLOW   001000000000	/* flexible hw flow_ctrl */
>  #define CIBAUD	  002003600000	/* input baud rate (not used) */
>  #define CMSPAR	  010000000000		/* mark or space (stick) parity */
>  #define CRTSCTS	  020000000000		/* flow control */

> It's only i386 yet, but please comment on it!

I won't comment on the code itself, as I don't know the 2.4.x serial
driver all that good:) Of course, non-i386 code would be cool, too:)

MfG, JBG

-- 
   Jan-Benedict Glaw       jbglaw@xxxxxxxxxx    . +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
   ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

Attachment: signature.asc
Description: Digital signature