Re: microcode_ctl question (fwd)

From: Tigran Aivazian
Date: Thu May 06 2004 - 08:32:00 EST


On Thu, 6 May 2004, Dave Jones wrote:
> I fixed up microcode.c to use on_each_cpu() last year sometime, which
> I thought should fix things up wrt preemption. Can you point to the
> bits you think are still problematic ?

Ok, just looked at the definition of on_each_cpu() and I can see that it
is disabling/enabling preemption explicitly, so there are no problems.

I assumed that on_each_cpu() is just a new 2.6 name for the old
smp_call_function(), that is why I thought there may be problems with
preemption. Thanks for clarifying this.

Kind regards
Tigran

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/