Re: Cache queue_congestion_on/off_threshold

From: Jens Axboe
Date: Thu May 06 2004 - 01:44:27 EST


On Wed, May 05 2004, Andrew Morton wrote:
> Jens Axboe <axboe@xxxxxxx> wrote:
> >
> > Do you have any numbers at all for this? I'd say these calculations are
> > severly into the noise area when submitting io.
>
> The difference will not be measurable, but I think the patch makes sense
> regardless of what the numbers say.

Humm dunno, I'd rather save the sizeof(int) * 2.

> I uninlined the new function though. Two callsites, both slowpath...

The more reason not to make it static :). I don't feel too strongly
about it though.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/