Re: PCI devices with no PCI_CACHE_LINE_SIZE implemented

From: Matt Domsch
Date: Wed May 05 2004 - 17:50:02 EST


On Wed, May 05, 2004 at 03:31:02PM -0700, Greg KH wrote:
> On Thu, Apr 29, 2004 at 02:53:01PM -0500, Matt Domsch wrote:
> > a) need this be a warning, wouldn't KERN_DEBUG suffice, if a message
> > is needed at all? This is printed in pci_generic_prep_mwi().
>
> Yes, we should make that KERN_DEBUG. I don't have a problem with that.
> Care to make a patch?

Appended for 2.6.6-rc3. I'll send a 2.4.x patch separately.

Thanks,
Matt

--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

===== drivers/pci/pci.c 1.65 vs edited =====
--- 1.65/drivers/pci/pci.c Fri Mar 26 10:58:01 2004
+++ edited/drivers/pci/pci.c Wed May 5 17:39:08 2004
@@ -640,7 +640,7 @@
if (cacheline_size == pci_cache_line_size)
return 0;

- printk(KERN_WARNING "PCI: cache line size of %d is not supported "
+ printk(KERN_DEBUG "PCI: cache line size of %d is not supported "
"by device %s\n", pci_cache_line_size << 2, pci_name(dev));

return -EINVAL;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/