Re: [PATCH 2.6.6-rc3] Add class support to drivers/usb/misc/tiglusb.c

[Greg KH]

On Wed, May 05, 2004 at 03:23:51PM -0700, Hanna Linder wrote:
> +out_class:
> +	class_simple_device_remove(MKDEV(TIUSB_MAJOR, TIUSB_MINOR + s->minor));
> +	class_simple_destroy(tiglusb_class);

Ick, don't destroy the whole class.  Not good.

> +	class_simple_device_remove(MKDEV(TIUSB_MAJOR, TIUSB_MINOR + s->minor));
> +	class_simple_destroy(tiglusb_class);

Same thing here, you don't have to delete the class, only the class
device.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/