Re: [PATCH] mxcsr patch for i386 & x86-64

[Linus Torvalds]

On Tue, 4 May 2004, Kamble, Nitin A wrote:
>
>      Attached is the patch to enable proper mxcsr register masking in
> the Linux Kernel. 
> 
> Please refer to IA32 Software Developer's Manual, Volume 1, Section
> 11.6.6 for more details.

Ahh. Have we verified that the new semantics of that MXCSR_MASK field 
works on non-intel CPU's too?

It would also (in my opinion) make sense to just export the 
"common_mxcsr_mask" (and probably just rename it as "mxcsr_feature_mask" 
or something - where does that "common" come from? Is it just to imply 
that it's the bits that all CPU's support "in common", or what?

Right now you export a function that does just a simple mask operation, 
and quite frankly, that just seems to make it less clear what the code is 
doing. So who not get rid of that "set_fpu_mxcsr()" function, and just 
replace all the "0xffbf" uses with "mxcsr_feature_mask"?

Hmm?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/