Re: 2.6.6-rc3: modular DVB tda1004x broken

From: Andrew Morton
Date: Sat May 01 2004 - 17:16:57 EST


Adrian Bunk <bunk@xxxxxxxxx> wrote:
>
> Please _undo_ the patch below.
>
> cu
> Adrian
>
> --- a/drivers/media/dvb/frontends/tda1004x.c Tue Apr 27 18:37:15 2004
> +++ b/drivers/media/dvb/frontends/tda1004x.c Tue Apr 27 18:37:15 2004
> @@ -188,7 +190,6 @@
> static struct fwinfo tda10046h_fwinfo[] = { {.file_size = 286720,.fw_offset = 0x3c4f9,.fw_size = 24479} };
> static int tda10046h_fwinfo_count = sizeof(tda10046h_fwinfo) / sizeof(struct fwinfo);
>
> -static int errno;

Would be better to export sys_open() and sys_lseek() to GPL modules rather
than persisting with this cruft.

This driver was going to be converted to use the firmware loader API?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/