Re: Large inlines in include/linux/skbuff.h

From: Andi Kleen
Date: Thu Apr 22 2004 - 10:02:34 EST

James Morris <jmorris@xxxxxxxxxx> writes:

> On Wed, 21 Apr 2004, Denis Vlasenko wrote:
>> What shall be done with this? I'll make patch to move locking functions
>> into net/core/skbuff.c unless there is some reason not to do it.
> How will these changes impact performance? I asked this last time you
> posted about inlines and didn't see any response.

I don't think it will be an issue. The optimization guidelines
of AMD and Intel recommend to move functions that generate
more than 30-40 instructions out of line. 100 instructions
is certainly enough to amortize the call overhead, and you
safe some icache too so it may be even faster.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at