Re: radeonfb broken

From: David Eger
Date: Tue Apr 20 2004 - 18:26:15 EST

On Mon, Apr 19, 2004 at 10:31:27AM -0400, Timothy Miller wrote:
>Ah, so you are the one who wrote the Radeon driver? Thanks for the fix.

Originally it was Ani Joshi's driver. Now BenH maintains it.
I just wrote the acceleration code for radeon for 2.6 ;-)

>One question I have is how to turn on acceleration in the 2.6 kernel.

Funny you should ask. We're discussing over on the fbdev list
( ) why it's so slow and how to fix it.
It turns out that the fbcon layer has some heuristics to decide how
best to accelerate text rendering (i.e., redraw, call driver accel routines,
or do a screen-to-screen bitblt). These heuristics are just plain *bad*.
At the moment, I just comment out the logic and hard-wire the choice
to "use the driver accel routines, dumbass" as in the excerpt below.

We ought to fix this logic so the video cards indicate which method
is best. The current fields in fb_fix_screeninfo don't really
convey the message well, as you can see in the logic below..

Excerpt from linux/drivers/video/console/fbcon.c:

#define divides(a, b) ((!(a) || (b)%(a)) ? 0 : 1)

/* ... */

static __inline__ void updatescrollmode(struct display *p, struct
vc_data *vc)
struct fb_info *info = registered_fb[(int) con2fb_map[vc->vc_num]];

int m;
/*if (p->scrollmode & __SCROLL_YFIXED)
if (divides(info->fix.ywrapstep, vc->vc_font.height) &&
divides(vc->vc_font.height, info->var.yres_virtual))
else if (divides(info->fix.ypanstep, vc->vc_font.height) &&
info->var.yres_virtual >= info->var.yres +
else if (p->scrollmode & __SCROLL_YNOMOVE)
p->scrollmode = (p->scrollmode & ~__SCROLL_YMASK) | m;

- end Excerpt

So the new driver will work once we patch it to tell fbcon not to be
stupid ;-)

sorry, i'm not sure about setting initial resolution with kernel arguments..


----- End forwarded message -----
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at