Re: Fix UDF-FS potentially dereferencing null

From: viro
Date: Fri Apr 16 2004 - 18:36:56 EST

On Sat, Apr 17, 2004 at 12:18:23AM +0100, Dave Jones wrote:
> On Fri, Apr 16, 2004 at 07:13:04PM -0400, Jeff Garzik wrote:
> > >Check in question is a BS - it never gets NULL passed as dir.
> >
> > Yes, it looks like a lot of these NULL checks caught can be fixed simply
> > by removing bogus and/or redundant checks.
> And there's a *lot* of them. Those half dozen or so patches earlier were
> results of just a quick random skim of the list the coverity folks came up with.
> It'll take a lot of effort to 'fix' them all, and given the non-severity
> of a lot of them, I'm not convinced it's worth the effort.

We really ought to kill just-in-case checks like that - they only obfuscate
the code _and_ hide bugs. The thing we must *not* do is "closing" the
items in that list by adding meaningless precautions of that sort.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at