Re: [RFC] fix sysfs symlinks

From: viro
Date: Wed Apr 14 2004 - 02:03:22 EST


On Wed, Apr 14, 2004 at 12:10:16PM +0530, Maneesh Soni wrote:
> I am not sure, if pinning the kobject for the life time of symlink (dentry)
> may result in same problems like rmmod hang which we saw in case of pinning
> kobject for the life time of its directory (dentry).

Erm... If rmmod _ever_ waits for refcount on kobject to reach zero, it's
already broken. Do you have any examples of such behaviour?

> + pr_debug("%s: path = '%s'\n", __FUNCTION__, path);
> +
> + return error;

ITYM
return 0;

BTW, replace leading spaces with tab, please - you've got a tabdamage
very visible in patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/