Re: [PATCH] Increase number of dynamic inodes in procfs (2.6.5)

From: Andrew Morton
Date: Wed Apr 14 2004 - 00:21:35 EST


Olof Johansson <olof@xxxxxxxxxxxxxx> wrote:
>
> On Tue, 13 Apr 2004, Andrew Morton wrote:
>
> > > and changes the inode number
> > > allocator to use a growable linked list of bitmaps.
> >
> > This open-codes a simple version of lib/idr.c. Please use lib/idr.c
> > instead. There's an example in fs/super.c
>
> The drawback of using lib/idr.c is the increased memory consumption for
> keeping track of the pointers that are not used. For 100k entries that's
> 800KB lost (64-bit arch).

Which is less that 2% of the space which is used by the 100k inodes.

We've previously discussed allocating the idr pointer array separately, but
the extra cache miss for the users who need it, plus the 2% argument keep
on trumping that. (We could avoid the cache miss with zero-length-array
tricks, actually).

> I've abstracted out Martin Bligh's and Ingo Molnar's scalable bitmap
> allocator that is used by the PID allocator.

Your current requirement does not appear to justify this additional
infrastructure.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/