Re: [PATCH][RFC] sort out CLOCK_TICK_RATE usage [1/3]

[Miles Bader]

Thorsten Kranzkowski <dl8bcu@xxxxxxxxx> writes:
> 	config INPUT_PCSPKR
> 		tristate "PC Speaker support"
> 		depends on INPUT && INPUT_MISC
> 
> I'm by no means a Kconfig expert, but I read this as there's nothing 
> that prevents you to select INPUT_PCSPKR on every architecture.

Indeed, but the code (pcspkr.c) looks completely non-portable, e.g.:

   outb_p(inb_p(0x61) | 3, 0x61);

[no comment]

So I'd guess that the Kconfig file should have more dependencies added;
what they are I have no idea.  [I guess it has something to do with old
ISA-bus-compatibility stuff.]

> > anywhere, and don't even know what an 8253 is... [so it would be damn
> > silly to have <asm/8253pit.h> as a required header!]
> 
> Ok, I won't create one, then. (just to be shure: asm-v850, right?) 

Yeah, v850.  I'd think you shouldn't do it for any arch except those
you know actually support this stuff.

-Miles
-- 
"Unless there are slaves to do the ugly, horrible, uninteresting work, culture
and contemplation become almost impossible. Human slavery is wrong, insecure,
and demoralizing.  On mechanical slavery, on the slavery of the machine, the
future of the world depends." -Oscar Wilde, "The Soul of Man Under Socialism"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/