RE: [PATCH] 2.6.5- es7000 subarch update

From: Protasevich, Natalie
Date: Mon Apr 12 2004 - 22:46:20 EST


Hi Len,

>The ES7000 sure is a great tester of the over-ride code!

Yes, indeed...

>But I don't like the proposal to selectively invalidate
>existing mp_irqs[] entries.
>I think the proper fix is to parse the over-ride entries before
>filling in the (remaining) identity mappings. This also gets
>rid of the special case for IRQ2, which would be handled exactly
>like the mappings to < 16 on the ES7000 above.

This is great idea! I know that the patch I suggested was "patching the symptom", not really addressing the cause. I didn't really expect it to be used, mostly just to illustrate the problem.

>Perhaps I should send you a patch you can test on the ES7000,
>since I don't have one of those?

Yes, please send me the patch and I will test it immediately.

>In any case, I'd prefer that proposed patches to this code come
>through me, since it is ACPI specific.

Actually, I was just looking for you, and this is my email to one of my friends, who I think won't get it till tomorrow: "The alternative patch I came up with I think is correct, but looks really ugly. There are like 3 or 4 places where it can be done, maybe someone could give me a hand to decide where to put the fix. Who is actually in charge of the mpparse and things like that I could cc to?"
:)
Thanks,
--Natalie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/