Re: [ACPI] Re: [PATCH] filling in ACPI method access via sysfsnamespace

From: Alex Williamson
Date: Sat Apr 10 2004 - 15:44:47 EST


On Fri, 2004-04-09 at 23:31, John Belmonte wrote:
>
> You may want to look at the acpi-devel thread "[rfc] generic testing
> ACPI module", where this issue was discussed
> (http://sourceforge.net/mailarchive/message.php?msg_id=7455349).

Ok, I took a look. The open/write/read/close interface seems to be
the best approach. It shouldn't be too hard, except the read/write
interfaces don't pass in the attribute pointer like they do for the
show/store interface. Is this a bug?

A nice feature of the current implementation is that I have one show
function that reads the method name out of the attribute structure.
With the bin_file interface, I'd need to have a different read/write
function for every possible method on a kobject. I also lose the
convenience of being able extend the container structure to meet my
needs. Am I strecthing the use of the bin_file too far or should these
interfaces pass the attribute pointer? Thanks,

Alex

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/