Re: dd patch to remove noctty

[Jim Meyering]

Paul Eggert <eggert@xxxxxxxxxxx> wrote:
> Philippe Troin <phil@xxxxxxxx> writes:
>
>> noctty definitely seems overkill... I can't see why dd would ever want
>> to open a file without O_NOCTTY.
>
> Good point; it's just a confusion for the user.  Here's a patch to
> cause dd to always use O_NOCTTY.  If someone ever needs it the other
> way (not likely) I suppose we can add a "ctty" flag.
>
> 2004-04-08  Paul Eggert  <eggert@xxxxxxxxxxx>
>
> 	* NEWS: Remove noctty flag from dd.  Suggested by Philippe Troin.
> 	* doc/coreutils.texi (dd invocation): Likewise.
> 	* src/shred.c (O_NOCTTY): Remove redundant decl.
> 	* src/dd.c (flags, usage): Remove noctty flag.
> 	(main): Always use O_NOCTTY when opening files.

Applied.  Thanks!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/