Re: dd PATCH: add conv=direct

[Paul Jarc]

Paul Eggert <eggert@xxxxxxxxxxx> wrote:
> Jim Meyering <jim@xxxxxxxxxxxx> writes:
>> 2004-04-08  Jim Meyering  <jim@xxxxxxxxxxxx>
>>
>> 	* src/dd.c (set_fd_flags): Don't OR in -1 when fcntl fails.
>
> Doesn't that fix generate worse code in the usual case, since it
> causes two conditional branches instead of one?

I think it's unnecessary anyway - if old_flags is -1, then the
conditional jumps to error() before looking at new_flags at all.


paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/