Re: [PATCH 2.6] Add missing MODULE_PARAM to dummy.c (and MAINTAINERShip)

[Chris Wright]

* Jose Luis Domingo Lopez (linux-kernel@xxxxxxxxxxxxx) wrote:
> diff -Nrup linux-2.6.5/drivers/net/dummy.c linux-2.6.5-new/drivers/net/dummy.c
> --- linux-2.6.5/drivers/net/dummy.c	2004-04-04 17:45:54.000000000 +0200
> +++ linux-2.6.5-new/drivers/net/dummy.c	2004-04-08 19:23:23.000000000 +0200
> @@ -89,7 +89,8 @@ static struct net_device_stats *dummy_ge
>  static struct net_device **dummies;
>  
>  /* Number of dummy devices to be set up by this module. */
> -module_param(numdummies, int, 0);
> +MODULE_PARM(numdummies, "i");
> +MODULE_PARM_DESC(numdummies, "Maximum number of dummy devices (defaults to one)");

this is going backwards.  module_param is the newer (preferred) interface.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/