Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix

[William Lee Irwin III]

On Mon, 29 Mar 2004, Andrew Morton wrote:
>> hmm, yes, we have pages which satisfy PageSwapCache(), but which are not
>> actually in swapcache.
>> 
>> How about we use the normal pagecache APIs for this?
>> 
>> +	add_to_page_cache(page, &swapper_space, entry.val, GFP_NOIO);
>>...  
>> +	remove_from_page_cache(page);

On Mon, Mar 29, 2004 at 11:24:58PM +0100, Hugh Dickins wrote:
> Much nicer, and it'll probably appear to work: but (also untested)
> I bet you'll need an additional page_cache_release(page) - damn,
> looks like hugetlbfs has found a use for that tiresome asymmetry.
> Hugh

The good news is that the use isn't particularly essential.


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/