Re: [PATCH] ppc32: Fix sector_t definition with CONFIG_LBD

From: Andrew Morton
Date: Mon Mar 29 2004 - 02:07:22 EST


Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> sector_t depends on CONFIG_LBD but include/config.h may not be there
> thus causing interesting breakage in some places...

Nasty.

> Here's the fix for ppc32 (problem found by Roman Zippel, other archs
> need a similar fix).

Three of them.

25-akpm/include/asm-s390/types.h | 2 ++
25-akpm/include/asm-sh/types.h | 2 ++
25-akpm/include/asm-x86_64/types.h | 2 ++
3 files changed, 6 insertions(+)

diff -puN include/asm-s390/types.h~types_h-needs-config_h include/asm-s390/types.h
--- 25/include/asm-s390/types.h~types_h-needs-config_h 2004-03-28 23:02:57.481365480 -0800
+++ 25-akpm/include/asm-s390/types.h 2004-03-28 23:02:57.486364720 -0800
@@ -50,6 +50,8 @@ typedef __signed__ long saddr_t;
*/
#ifdef __KERNEL__

+#include <linux/config.h>
+
#ifndef __s390x__
#define BITS_PER_LONG 32
#else
diff -puN include/asm-sh/types.h~types_h-needs-config_h include/asm-sh/types.h
--- 25/include/asm-sh/types.h~types_h-needs-config_h 2004-03-28 23:02:57.482365328 -0800
+++ 25-akpm/include/asm-sh/types.h 2004-03-28 23:02:57.486364720 -0800
@@ -31,6 +31,8 @@ typedef unsigned long long __u64;
*/
#ifdef __KERNEL__

+#include <linux/config.h>
+
#define BITS_PER_LONG 32

#ifndef __ASSEMBLY__
diff -puN include/asm-x86_64/types.h~types_h-needs-config_h include/asm-x86_64/types.h
--- 25/include/asm-x86_64/types.h~types_h-needs-config_h 2004-03-28 23:02:57.484365024 -0800
+++ 25-akpm/include/asm-x86_64/types.h 2004-03-28 23:02:57.486364720 -0800
@@ -29,6 +29,8 @@ typedef unsigned long long __u64;
*/
#ifdef __KERNEL__

+#include <linux/config.h>
+
#define BITS_PER_LONG 64

#ifndef __ASSEMBLY__

_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/