Re: [PATCH 24/44] Workaround i8042 chips with broken MUX mode

[Dmitry Torokhov]

On Saturday 27 March 2004 07:29 pm, Andries Brouwer wrote:
> On Tue, Mar 16, 2004 at 10:24:09AM -0800, Dmitry Torokhov wrote:
> > Vojtech Pavlik wrote:
> 
> > > +	/* Workaround for broken chips which seem to
> > support MUX, but in reality don't. */
> 
> Why call them "broken"? Better to delete that word.
> 
> > > +	/* They all report version 12.10 */
> > > +	if (mux_version == 0xCA)
> > > +		return -1;
> > 
> > I think it should be 0xAC (0xA4 with 4th bit flipped)
> > as the version reported is 10.12.
> 
> Yes. I have seen one such report. Have there been more?
>

As it turned out its not the chip but USB legacy emulation that
gets in the way of synaptics query. Actually alot of problems were
linked to broken legacy emulation implementations, Vojtech mentioned
that PCI quirk to turn legacy emulation off may be appropriate.
 
> The Synaptics multiplexing proposal uses 0xf0, 0x56, 0xa4
> to activate and 0xf0, 0x56, 0xa5 to deactivate.
> In both cases the replies must be 0xf0, 0x56, version.
> 
> Thus, I suppose one might get a more robust detection
> by checking that both the activation and deactivation
> sequences yield the same version.
>

Unfortunately in this particular case it looks like something flips
4th bit on some (but not all, like every 3rd) bytes, so it may very
well respond with 0xAC to both queries.
  
-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/