Re: [linux-usb-devel] Re: [OOPS] reproducible oops with 2.6.5-rc2-bk3

[Colin Leroy]

Hi again,

> > If I understand it well, this changes the previous default behaviour;
> > intf->cur_altsetting will be intf->altsetting[0], like before, only if
> > there's no intf->altsetting[i].desc.bAlternateSetting == 0.
>
> That's right.  However, the oops you saw shouldn't happen so long as
> intf->cur_altsetting points to something valid.  I got the impression
that
> in the cdc-acm probe routine maybe it was a null pointer.

Additionally, there's still a reference to altsetting[0] in cdc-acm.c (in
acm_ctrl_msg()), I don't know if it's intentional or should have been
converted from
    acm->control->altsetting[0].desc.bInterfaceNumber
to
    acm->control->cur_altsetting.desc.bInterfaceNumber
?
-- 
Colin
  This message represents the official view of the voices
  in my head.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/