Re: CONFIG_PREEMPT and server workloads

From: Takashi Iwai
Date: Fri Mar 19 2004 - 15:49:57 EST


At Thu, 18 Mar 2004 15:57:45 -0800,
Andrew Morton wrote:
>
> Chris Mason <mason@xxxxxxxx> wrote:
> >
> > > What we're doing here is walking (under spinlock) a ring of buffers
> > > searching for unlocked dirty ones to write out.
> > >
> > > Suppose the ring has thousands of locked buffers and there is a RT task
> > > scheduling at 1kHz. Each time need_resched() comes true we break out of
> > > the search, schedule away and then restart the search from the beginning.
> > >
> > Why not just put all the locked buffers onto a different list as you
> > find them or lock them. That way you can always make progress...
>
> Coz that made me look at the code and hence rewrite the whole thing, damn
> you. It's definitely better, but is of scary scope.

wow, interesting, i'll give a shot with your patch.
thanks!


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/