Re: [SPARC64][PPC] strange error ..

[Randy.Dunlap]

On Mon, 15 Mar 2004 14:08:07 -0700 Tom Rini wrote:

| On Mon, Mar 15, 2004 at 12:54:17PM -0800, Randy.Dunlap wrote:
| > On Mon, 15 Mar 2004 13:43:46 -0700 Tom Rini wrote:
| > | On Mon, Mar 15, 2004 at 12:39:53PM -0800, David S. Miller wrote:
| > | 
| > | > On Mon, 15 Mar 2004 12:00:26 -0700
| > | > Tom Rini <trini@xxxxxxxxxxxxxxxxxxx> wrote:
| > | > 
| > | > > That leaves the more general problem of <asm/unistd.h> uses 'asmlinkage'
| > | > > on platforms where either (or both) of the following can be true:
| > | > > - 'asmlinkage' is a meaningless term, and shouldn't be used.
| > | > > - <asm/unistd.h> doesn't include <linux/linkage.h> so it's possible
| > | > >   another file down the line breaks.
| > | > 
| > | > I think the best fix is to include linux/linkage.h in asm/unistd.h as
| > | > you seem to be suggesting, and therefore that is the change I will
| > | > push off to Linus to fix this on sparc32 and sparc64.
| > | 
| > | Erm, if I read include/asm-sparc{,64}/linkage.h right, 'asmlinkage' ends
| > | up being defined to ''.  So why not just remove 'asmlinkage' from the
| > | offending line in unistd.h ?
| > 
| > For future-proofing:  so that it will be like all other $arch/unistd.h,
| 
| It's not nearly all other $arch/unistd.h, it's arm, arm26, i386, ia64,
| ppc64, v850 and x86_64.  Of which, only i386, ia64 and x86_64 arm* do
| anything in <asm/linkage.h>.
| 
| So if we really do want to go down the future-proof <asm-*/unistd.h>
| from the ia-centric folks (<grin>) road, we'd be better off with a patch
| to fix everyone else's $arch/unistd.h.

OK.  :)

| > so that when someone changes the meaning of it, it will just work...?
| 
| The meaning of asmlinkage ?

Sure, it could mean something in the future, for any arch.

Your simple fix sounds good for 2.6.x.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/