Re: [PATCH] Fix a 64bit bug in kobject module request

[Mikael Pettersson]

On Thu, 11 Mar 2004 05:09:43 +0100, Andi Kleen wrote:
>>From Takashi Iwai
>
>kobj_lookup had a 64bit bug, which caused the request of a unknown
>character device to burn CPU instead of failing quickly.
>
>diff -burpN -X ../KDIFX linux-vanilla/drivers/base/map.c linux-2.6.4-amd64/drivers/base/map.c
>--- linux-vanilla/drivers/base/map.c	2003-09-23 08:03:40.000000000 +0200
>+++ linux-2.6.4-amd64/drivers/base/map.c	2004-03-08 15:23:45.000000000 +0100
>@@ -96,7 +96,7 @@ struct kobject *kobj_lookup(struct kobj_
> {
> 	struct kobject *kobj;
> 	struct probe *p;
>-	unsigned best = ~0U;
>+	unsigned long best = ~0UL;
> 
> retry:
> 	down_read(domain->sem);

My Athlon64 (FC1/x86_64 user-space) has been having mysterious
module autoloading failures where some modules (char-major-10-$N)
autoloaded just fine, but many ({char,block}-major-$N) did not.
This patch solved that problem.

Thanks Andi.

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/