Re: (0 == foo), rather than (foo == 0)

From: Stefan Smietanowski
Date: Thu Mar 11 2004 - 05:31:15 EST

Hi Måns.

The warning should be there whether there are parenthesis or not,
and it should state that you should have an explicit inequality
expression. So if you have
if (a = b) ...
and you really _mean_ that, then the way to write it sanely is to
just write it as
if ((a = b) != 0)
which makes it much clearer what you're actually doing.

Or actually change it to

a = b;
if (a)

That doesn't work with while().

True. Didn't think of that but then the example used
was an if().

// Stefan
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at