Re: [PATCH 2.6] Intersil Prism54 wireless driver

From: Jeff Garzik
Date: Wed Mar 10 2004 - 12:33:00 EST

Jean Tourrilhes wrote:
On Wed, Mar 10, 2004 at 04:55:48PM +0000, Christoph Hellwig wrote:
+MODULE_PARM(init_mode, "i");
+ "Set card mode:\n0: Auto\n1: Ad-Hoc\n2: Managed Client (Default)\n3: Master / Access Point\n4: Repeater (Not supported yet)\n5: Secondary (Not supported yet)\n6: Monitor");

Please use module_param

I would even say that this is useless because the driver
support WE, and WE scripts set the mode before the card is up.

module_param() is a type-safe interface roughly identical to MODULE_PARM(). Therefore, if MODULE_PARM() works, module_param() works also.

diff -Naur -X /home/mcgrof/lib/dontdiff linux-2.6.3/drivers/net/wireless/prism54/isl_wds.c linux-2.6.3-prism54/drivers/net/wireless/prism54/isl_wds.c
--- linux-2.6.3/drivers/net/wireless/prism54/isl_wds.c Thu Jan 1 00:00:00 1970
+++ linux-2.6.3-prism54/drivers/net/wireless/prism54/isl_wds.c Thu Mar 4 02:00:01 2004

WDS doesn't belong into a driver but in higher-level code.

The big 802.11 reorg can only happen when HostAP is in the

ISTR it needed some cleaning up before it could go in.

Further, in Linux, there is _never_ a requirement that "this driver be included before we can clean up." You can start the re-org any time you wish. Out-of-tree maintainers can follow the re-org, sometimes more easily.


P.S. I still need to look at your netlink thing. Seems like a decent direction.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at